[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4BAF8D79.4090900@cs.helsinki.fi>
Date: Sun, 28 Mar 2010 20:10:17 +0300
From: Pekka Enberg <penberg@...helsinki.fi>
To: Eric Dumazet <eric.dumazet@...il.com>
CC: Christoph Lameter <cl@...ux-foundation.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] slub: Potential stack overflow
Eric Dumazet wrote:
> Le mercredi 24 mars 2010 à 16:14 -0500, Christoph Lameter a écrit :
>> Here is a patch for the second case. I think its better since it results
>> in an error display and it avoids the alloc for each slab. Add this piece
>> to your patch?
>>
>> Signed-off-by: Christoph Lameter <cl@...ux-foundation.org>
>
> Sure, here is third version :
>
> Thanks
>
> [PATCH] slub: Potential stack overflow
>
> I discovered that we can overflow stack if CONFIG_SLUB_DEBUG=y and use
> slabs with many objects, since list_slab_objects() and process_slab()
> use DECLARE_BITMAP(map, page->objects);
>
> With 65535 bits, we use 8192 bytes of stack ...
>
> Switch these allocations to dynamic allocations.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Christoph Lameter <cl@...ux-foundation.org>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists