linux-kernel - [PATCH] [REGRESSION 2.6.33] x86: Handle overlapping mptables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100329074111.GA22821@basil.fritz.box>
Date:	Mon, 29 Mar 2010 09:41:11 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	x86@...nel.org, trenn@...e.de, ak@...ux.intel.com
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] [REGRESSION 2.6.33] x86: Handle overlapping mptables

[REGRESSION] x86: Handle overlapping mptables

We found a system where the MP table MPC and MPF structures overlap. 

That doesn't really matter because the mptable is not used anyways with ACPI,
but it leads to a panic in the early allocator due to the overlapping
reservations in 2.6.33.

Earlier kernels handled this without problems.

Simply change these reservations to reserve_early_overlap_ok to avoid
the panic.

Reported-by: Thomas Renninger <trenn@...e.de>
Tested-by: Thomas Renninger <trenn@...e.de>
Signed-off-by: Andi Kleen <ak@...ux.intel.com>

---
 arch/x86/kernel/cpu/perfctr-watchdog.c |   10 ++++++++--
 arch/x86/kernel/mpparse.c              |    4 ++--
 2 files changed, 10 insertions(+), 4 deletions(-)

Index: linux-2.6.33-ak/arch/x86/kernel/mpparse.c
===================================================================
--- linux-2.6.33-ak.orig/arch/x86/kernel/mpparse.c
+++ linux-2.6.33-ak/arch/x86/kernel/mpparse.c
@@ -664,7 +664,7 @@ static void __init smp_reserve_memory(st
 {
 	unsigned long size = get_mpc_size(mpf->physptr);
 
-	reserve_early(mpf->physptr, mpf->physptr+size, "MP-table mpc");
+	reserve_early_overlap_ok(mpf->physptr, mpf->physptr+size, "MP-table mpc");
 }
 
 static int __init smp_scan_config(unsigned long base, unsigned long length)
@@ -693,7 +693,7 @@ static int __init smp_scan_config(unsign
 			       mpf, (u64)virt_to_phys(mpf));
 
 			mem = virt_to_phys(mpf);
-			reserve_early(mem, mem + sizeof(*mpf), "MP-table mpf");
+			reserve_early_overlap_ok(mem, mem + sizeof(*mpf), "MP-table mpf");
 			if (mpf->physptr)
 				smp_reserve_memory(mpf);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/