linux-kernel - Re: [PATCH 2/5] Make room for other tps6507x drivers to have board specific initialization data.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100329125440.GC8434@rakim.wolfsonmicro.main>
Date:	Mon, 29 Mar 2010 13:54:40 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Todd Fischer <todd.fischer@...gerun.com>
Cc:	linux-kernel@...r.kernel.org,
	davinci-linux-open-source@...ux.davincidsp.com,
	sameo@...ux.intel.com, lrg@...mlogic.co.uk
Subject: Re: [PATCH 2/5]  Make room for other tps6507x drivers to have
 board specific initialization data.

On Fri, Mar 26, 2010 at 02:11:29PM -0600, Todd Fischer wrote:
> Need mfd structure that can hold pointers to sub-driver initialization
> and run time data.

Please provide a more verbose changelog.  What needs this structure?

>  	/**
> +	 * tps_board points to pmic related constants
> +	 * coming from the board-evm file.
> +	 */
> +
> +	tps_board = (struct tps6507x_board *)client->dev.platform_data;

There's no need to cast away from void and you ought to be using
dev_get_platdata().

> +	if (!tps_board)
> +		return -EIO;
> +

This seems like the wrong error code to be using here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/