linux-kernel - Re: KVM bug, git bisected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1269880140.12097.356.camel@laptop>
Date:	Mon, 29 Mar 2010 18:29:00 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Rik van Riel <riel@...hat.com>
Cc:	Kent Overstreet <kent.overstreet@...il.com>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>
Subject: Re: KVM bug, git bisected

On Mon, 2010-03-29 at 12:11 -0400, Rik van Riel wrote:
> On 03/27/2010 08:43 AM, Kent Overstreet wrote:
> > commit 5beb49305251e5669852ed541e8e2f2f7696c53e
> > Author: Rik van Riel <riel@...hat.com>
> > Date: Fri Mar 5 13:42:07 2010 -0800
> >
> > mm: change anon_vma linking to fix multi-process server scalability issue
> >
> > I get this when starting kvm. The warning hasn't caused me problems, but
> > I've also been getting a scheduling while atomic panic when I start kvm
> > that I can only reproduce when I don't want to. It's definitely config
> > dependent, I'd guess preempt might have something to do with it.
> 
>  From your trace, it looks like mm_take_all_locks is taking close
> to 256 locks, which is where the preempt_count could overflow into
> the softirq count.
> 
> Since kvm-qemu is exec'd, I am guessing you have a very large
> number of VMAs in your qemu process.  Is that correct?
> 
> Peter, would it be safe to increase PREEMPT_BITS to eg. 10?

Possibly, but who's to say the thing won't bloat to 65k at which it'll
hit the vma limit, but even that can be grown beyond that.

When we started out with this I predicted this would happen, the
following was said:

---
> When we created this the promise was that kvm would only do this on a
> fresh mm with only a few vmas, has that changed?

The number of vmas did increase, but not materially.  We do link with 
more shared libraries though.
---

That was when we broke the 48 barrier (jul'09), apparently we've now
bloated to beyond 256, at this rate 10 will not last 6 months.

Alternative we remove the preempt overflow warning, it shouldn't break,
although it all is very ugly..


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/