linux-kernel - Re: [BUG] No SPROM available!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 29 Mar 2010 20:57:50 +0200
From:	René Bolldorf <xsecute@...glemail.com>
To:	"John W. Linville" <linville@...driver.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [BUG] No SPROM available!

On 03/29/10 17:59, René Bolldorf wrote:
> Hi John,
>
> since commit fcb54b0bf7d3fe730c2b72e224bc616e358f24cb, my b43 (4312)
> device doesn't work.
>
> But the device have a sprom. Maybe the chip-status register check is wrong?
>
> +/** Macros to determine SPROM presence based on Chip-Status register. */
> +#define SSB_CHIPCO_CHST_4312_SPROM_PRESENT(status) \
> + ((status & SSB_CHIPCO_CHST_4325_SPROM_OTP_SEL) != \
> + SSB_CHIPCO_CHST_4325_OTP_SEL)

I have talked with my colleague and he have the same problem. I have 
made a patch , for me it works and should work for others too. My 
colleague testing this in the late evening.

diff --git a/include/linux/ssb/ssb_driver_chipcommon.h 
b/include/linux/ssb/ssb_driver_chipcommon.h
index 2cdf249..1e0b9cd 100644
--- a/include/linux/ssb/ssb_driver_chipcommon.h
+++ b/include/linux/ssb/ssb_driver_chipcommon.h
@@ -386,6 +386,7 @@


  /** Chip specific Chip-Status register contents. */
+#define SSB_CHIPCO_CHST_4312_SPROM_EXISTS	0x00000025
  #define SSB_CHIPCO_CHST_4322_SPROM_EXISTS	0x00000040 /* SPROM present */
  #define SSB_CHIPCO_CHST_4325_SPROM_OTP_SEL	0x00000003
  #define SSB_CHIPCO_CHST_4325_DEFCIS_SEL		0 /* OTP is powered up, use 
def. CIS, no SPROM */
@@ -403,7 +404,7 @@
  /** Macros to determine SPROM presence based on Chip-Status register. */
  #define SSB_CHIPCO_CHST_4312_SPROM_PRESENT(status) \
  	((status & SSB_CHIPCO_CHST_4325_SPROM_OTP_SEL) != \
-		SSB_CHIPCO_CHST_4325_OTP_SEL)
+		SSB_CHIPCO_CHST_4312_SPROM_EXISTS)
  #define SSB_CHIPCO_CHST_4322_SPROM_PRESENT(status) \
  	(status & SSB_CHIPCO_CHST_4322_SPROM_EXISTS)
  #define SSB_CHIPCO_CHST_4325_SPROM_PRESENT(status) \
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/