linux-kernel - Re: [PATCH] net/wireless/libertas: do not call wiphy_unregister() w/o wiphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201003301259.23973.hs4233@mail.mn-solutions.de>
Date:	Tue, 30 Mar 2010 12:59:23 +0200
From:	Holger Schurig <hs4233@...l.mn-solutions.de>
To:	Daniel Mack <daniel@...aq.de>
Cc:	linux-kernel@...r.kernel.org, Dan Williams <dcbw@...hat.com>,
	"John W. Linville" <linville@...driver.com>,
	Bing Zhao <bzhao@...vell.com>,
	libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net/wireless/libertas: do not call wiphy_unregister() w/o wiphy_register()

> I don't get your point. The patch I submitted fixes an Ooops in the
> driver, due to wrong handling of an API. What does that have to do with
> principle discussions about the frameworks in use?

I asked if there is a better method, and you said that you would test a better 
solution. That means that someone else should make a better solution.

I just pointed out that I won't be the one who creates the better solution, 
because for fundamental reasons I don't see the libertas+cfg80211 approach 
going forward. That issue has nothing to do with you or your patch, so please 
don't feel offended or confused.

Basically, I neither ack nor nak you patch. Given that it fixes an oops the 
patch should go in, and probably to stable at well. I just gave a hint, to 
make you think if you could come up with something better.

BTW, testing/fixing of failure paths in libertas as well as simplifying the 
call sequence of functions during initialisation could be quite useful.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/