linux-kernel - Re: [PATCH] drivers:staging: sources for HCI LL PM protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100330122440.1e3d8bf1@lxorguk.ukuu.org.uk>
Date:	Tue, 30 Mar 2010 12:24:40 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	pavan_savoy@...com
Cc:	marcel@...tmann.org, gregkh@...e.de, linux-kernel@...r.kernel.org,
	pavan_savoy@...oo.co.in
Subject: Re: [PATCH] drivers:staging: sources for HCI LL PM protocol


> +static struct ll_struct_s *ll;

More magic globals. I think this more than anything else demonstrates why
you need some kind of proper per device context passed around

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/