[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 29 Mar 2010 23:36:17 -0400
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: linux-kernel@...r.kernel.org, stable <stable@...nel.org>
Cc: Randy Dunlap <randy.dunlap@...cle.com>,
Eric Dumazet <dada1@...mosbay.com>,
Rusty Russell <rusty@...tcorp.com.au>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Tejun Heo <tj@...nel.org>, Ingo Molnar <mingo@...e.hu>,
Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Greg Kroah-Hartman <gregkh@...e.de>,
Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] modules fix incorrect percpu usage
* Mathieu Desnoyers (mathieu.desnoyers@...icios.com) wrote:
> Should use per_cpu_ptr() to obfuscate the per cpu pointers (RELOC_HIDE is needed
> for per cpu pointers).
>
> Introduced by commit:
>
> module.c: commit 6b588c18f8dacfa6d7957c33c5ff832096e752d3
>
> This patch should be queued for the stable branch, for kernels 2.6.29.x to
> 2.6.33.x.
> (tested on 2.6.33.1 x86_64)
It's actually needed for mainline too (2.6.34-rc2).
Thanks,
Mathieu
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> CC: Randy Dunlap <randy.dunlap@...cle.com>
> CC: Eric Dumazet <dada1@...mosbay.com>
> CC: Rusty Russell <rusty@...tcorp.com.au>
> CC: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> CC: Tejun Heo <tj@...nel.org>
> CC: Ingo Molnar <mingo@...e.hu>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: Linus Torvalds <torvalds@...ux-foundation.org>
> CC: Greg Kroah-Hartman <gregkh@...e.de>
> CC: Steven Rostedt <rostedt@...dmis.org>
> CC: stable <stable@...nel.org>
> ---
> kernel/module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6-lttng/kernel/module.c
> ===================================================================
> --- linux-2.6-lttng.orig/kernel/module.c 2010-03-29 23:47:05.000000000 -0400
> +++ linux-2.6-lttng/kernel/module.c 2010-03-29 23:47:27.000000000 -0400
> @@ -412,7 +412,7 @@ static void percpu_modcopy(void *pcpudes
> int cpu;
>
> for_each_possible_cpu(cpu)
> - memcpy(pcpudest + per_cpu_offset(cpu), from, size);
> + memcpy(per_cpu_ptr(pcpudest, cpu), from, size);
> }
>
> #else /* ... !CONFIG_SMP */
>
> --
> Mathieu Desnoyers
> Operating System Efficiency R&D Consultant
> EfficiOS Inc.
> http://www.efficios.com
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists