linux-kernel - Re: [PATCH] libertas/sdio: set ECSI and SCSI bits for 1-bit transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100330184046.GY30801@buzzloop.caiaq.de>
Date:	Tue, 30 Mar 2010 20:40:46 +0200
From:	Daniel Mack <daniel@...aq.de>
To:	Dan Williams <dcbw@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Alagu Sankar <alagusankar@...wise.com>,
	Volker Ernst <volker.ernst@...r.com>,
	"John W. Linville" <linville@...driver.com>,
	Holger Schurig <hs4233@...l.mn-solutions.de>,
	Bing Zhao <bzhao@...vell.com>,
	libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org,
	linux-mmc@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>
Subject: Re: [PATCH] libertas/sdio: set ECSI and SCSI bits for 1-bit
 transfers

On Tue, Mar 30, 2010 at 11:37:39AM -0700, Dan Williams wrote:
> On Tue, 2010-03-30 at 19:38 +0200, Daniel Mack wrote:
> > When operating in 1-bit mode, SDAT1 is used as dedicated interrupt line.
> > However, the 8686 will only drive this line when the ECSI and SCSI bits
> > are set in the CCCR_IF register.
> 
> While this looks fine enough to me, I don't have enough knowledge of the
> SDIO stack to know whether or not this would be considered a layering
> violation or not.  Given that I don't think there's an active maintainer
> for the SDIO subsystem though, I'd say it's fine enough for me...
> 
> Any thoughts David since it appears to be at least somewhat SPI related?

I believe that these bits in question are just abused in this case. The
device is not in SPI mode, so according to the specs, the bits shouldn't
make any difference. This makes me think that this is specific to
libertas, and doesn't belong in any lower level.

> Acked-by: Dan Williams <dcbw@...hat.com>

Thanks!

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/