linux-kernel - Re: [PATCH] drivers:staging: sources for ST core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Mar 2010 13:38:42 -0700
From:	Greg KH <gregkh@...e.de>
To:	Pavan Savoy <pavan_savoy@...com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, marcel@...tmann.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:staging: sources for ST core

On Tue, Mar 30, 2010 at 09:23:23PM +0530, Pavan Savoy wrote:
> Alan,
> 
> --- On Tue, 30/3/10, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> 
> > From: Alan Cox <alan@...rguk.ukuu.org.uk>
> > Subject: Re: [PATCH] drivers:staging: sources for ST core
> > To: pavan_savoy@...com
> > Cc: marcel@...tmann.org, gregkh@...e.de, linux-kernel@...r.kernel.org, pavan_savoy@...oo.co.in
> > Date: Tuesday, 30 March, 2010, 4:52 PM
> > > +/* all debug macros go in here
> > */
> > > +#define ST_DRV_ERR(fmt, arg...)? printk(KERN_ERR
> > "(stc):"fmt"\n" , ## arg)
> > > +#if defined(DEBUG)???
> > ??? /* limited debug messages */
> > > +#define ST_DRV_DBG(fmt, arg...)?
> > printk(KERN_INFO "(stc):"fmt"\n" , ## arg)
> > > +#define ST_DRV_VER(fmt, arg...)
> > > +#elif defined(VERBOSE)???
> > ??? /* very verbose */
> > > +#define ST_DRV_DBG(fmt, arg...)?
> > printk(KERN_INFO "(stc):"fmt"\n" , ## arg)
> > > +#define ST_DRV_VER(fmt, arg...)?
> > printk(KERN_INFO "(stc):"fmt"\n" , ## arg)
> > > +#else /* error msgs only */
> > > +#define ST_DRV_DBG(fmt, arg...)
> > > +#define ST_DRV_VER(fmt, arg...)
> > > +#endif
> > 
> > As Greg said earlier - needs to be using the standard debug
> > macros
> 
> Agree - It's all there because of the organization's coding standards.
> Will correct it.

Might you also want to correct your organization's coding standards to
follow the correct Linux kernel ones?  That way you will not have this
problem in the future.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/