linux-kernel - Re: [PATCH] Staging: Add new driver ipheth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100330221138.GA20765@suse.de>
Date:	Tue, 30 Mar 2010 15:11:39 -0700
From:	Greg KH <gregkh@...e.de>
To:	"L. Alberto Gim?nez" <agimenez@...valve.es>
Cc:	bzolnier@...il.com, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, alan@...ux.intel.com
Subject: Re: [PATCH] Staging: Add new driver ipheth

On Tue, Mar 30, 2010 at 11:58:22PM +0200, "L. Alberto Gim?nez" wrote:
> On 03/30/2010 11:45 PM, Greg KH wrote:
> > On Tue, Mar 30, 2010 at 11:34:24PM +0200, L. Alberto Gim??nez wrote:
> >> Add new driver to use tethering with an iPhone device to the staging tree.
> > 
> > Why the staging tree?
> > 
> > What is wrong with the driver that it needs to go there and not to the
> > main kernel tree?
> > 
> 
> Sorry, I thought that the first step was getting into staging.

For the majority of the drivers out there, no, this is not the first
step.  Especially ones as clean as this one.  Staging is only for the
"crap" code out there :)

> I ignored the fact that it needed a TODO file. I'm not either sure
> about where should it go since it uses the USB interface but in fact
> is used as a network device (drivers/net? drivers/usb?). My guess is
> drivers/net, but I'm pretty sure I'm wrong :)

drivers/net/usb/ would be the proper place for it.

> > Did you write this driver?  If not, please put a "From:" line that shows
> > who did write it.
> 
> Should I just add a "From: " email-like header in the patch, in the
> commit or in the body? I'm not sure how to do it.

Put it as the first line of the changelog comment in the email body, and
then when git applies it, the proper author will be credited.

care to try it again?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/