linux-kernel - Re: [PATCH] added S6E63M0 AMOLED LCD Panel driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100330160257.e5f978a9.akpm@linux-foundation.org>
Date:	Tue, 30 Mar 2010 16:02:57 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	InKi Dae <daeinki@...il.com>
Cc:	Pavel Machek <pavel@....cz>,
	linux-fbdev-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, kyungmin.park@...sung.com
Subject: Re: [PATCH] added S6E63M0 AMOLED LCD Panel driver.

On Fri, 26 Mar 2010 12:24:24 +0900
InKi Dae <daeinki@...il.com> wrote:

> +static int s6e63m0_ldi_init(struct s6e63m0 *lcd)
> +{
> +	int ret;
> +
> +	ret = s6e63m0_panel_send_sequence(lcd, SEQ_PANEL_CONDITION_SET);
> +	ret |= s6e63m0_panel_send_sequence(lcd, SEQ_DISPLAY_CONDITION_SET);
> +	ret |= s6e63m0_panel_send_sequence(lcd, SEQ_GAMMA_SETTING);
> +	ret |= s6e63m0_panel_send_sequence(lcd, SEQ_ETC_CONDITION_SET);
> +	ret |= s6e63m0_panel_send_sequence(lcd, SEQ_ACL_ON);
> +	ret |= s6e63m0_panel_send_sequence(lcd, SEQ_ELVSS_ON);
> +
> +	return ret;
> +}

Well.  If one call to s6e63m0_panel_send_sequence() returns -ENOMEM and
another call returns -EIO (for example), this function will return some
other, incorrect errno.

Which is a rather minor problem, unless some caller is explicitly
looking for some particular error code, which doesn't happen often.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/