lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Mar 2010 18:24:01 -0800 (PST) From: Joe Perches <joe@...ches.com> To: Pavan Savoy <pavan_savoy@...com> cc: Greg KH <gregkh@...e.de>, Alan Cox <alan@...rguk.ukuu.org.uk>, <marcel@...tmann.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] drivers:staging: sources for ST core On Wed, 31 Mar 2010, Pavan Savoy wrote: > +bool is_protocol_list_empty(void) > +{ > + unsigned char i = 0; > + pr_debug(" %s ", __func__); You need to add terminating '\n's to most all these messages. It's also not necessary to have leading or trailing whitespace. > +#ifdef VERBOSE > + printk(KERN_ERR "start data..\n"); > + for (i = 0; i < count; i++) /* no newlines for each datum */ > + printk(" %x", data[i]); > + printk(KERN_ERR "\n ..end data\n"); > +#endif print_hex_dump(KERN_ERR, "data: ", DUMP_PREFIX_OFFSET, 16, 1, data, count, true); cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists