linux-kernel - Re: [PATCH 3/4] include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BB2B65E.5030905@kernel.org>
Date:	Wed, 31 Mar 2010 11:41:34 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Lee Schermerhorn <Lee.Schermerhorn@...com>
CC:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, cl@...ux-foundation.org,
	mingo@...e.hu, adobriyan@...il.com, tglx@...utronix.de,
	hpa@...or.com, yi.zhu@...el.com, reinette.chatre@...el.com,
	ilw@...ux.intel.com, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH 3/4] include cleanup: Update gfp.h and slab.h includes
 to prepare for breaking implicit slab.h inclusion from percpu.h

Hello,

On 03/30/2010 11:30 PM, Lee Schermerhorn wrote:
> I rebased your series atop the mmotm dated 24march to test my "generic
> percpu numa_*_id()" series.  This largish patch [3/4] threw a few [13]
> rejects.  I'll list them below.  You've said that you're going to submit
> this to linux-next where it might not see the same rejects.  I built,
> booted and am using the resulting kernel on x86_64.

This series is already in linux-next from next-20100329.  I forgot to
run slabh-sweep.py script on new code in linux-next which led to
various build breakages.  Stephen fixed the ones which cause build
failures and I later ran the script on linux-next and sent out patches
to subsystem trees.  The good news is there was only one build
breakage from mainline code.  All else were new code in linux-next.
So, the conversion seems quite comprehensive.

> Building with allyesconfig, I found 15 additional files in the mmotm
> tree that will need an explicit include of slab.h added.  I have
> attached a patch that addresses these.
> 
> I have rebased my numa_*_id() series atop this mmotm, less the
> percpu.h/percpu-defs.h hack that led you down this path.  That kernel
> builds and boots fine.  I'm currently testing with and without
> memoryless nodes.  So far, this series looks good.

Great, can you please retry mm once it pulls in linux-next from
20100401?  That should have most of necessary fixes.

>  drivers/hwmon/tmp102.c              |    1 +
>  drivers/input/misc/ad714x.c         |    1 +
>  drivers/input/misc/pcf8574_keypad.c |    1 +
>  drivers/leds/leds-input.c           |    1 +
>  drivers/misc/hwlat_detector.c       |    1 +
>  drivers/mtd/sm_ftl.c                |    1 +
>  drivers/vbus/bus-proxy.c            |    1 +
>  kernel/debug/kdb/kdb_support.c      |    1 +
>  sound/soc/codecs/twl6040.c          |    1 +
>  sound/usb/endpoint.c                |    1 +
>  sound/usb/format.c                  |    1 +
>  sound/usb/helper.c                  |    1 +
>  sound/usb/mixer_quirks.c            |    1 +
>  sound/usb/pcm.c                     |    1 +
>  sound/usb/quirks.c                  |    1 +
>  15 files changed, 15 insertions(+)

Most of the above are the ones already fixed in linux-next.  Can you
please try out next-20100330?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/