linux-kernel - [PATCH-V2] OMAP: Fix for bus width which improves SD card's peformance.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x2q7f9d1ffb1003302307nb8e91be0o55da59c3375f1720@mail.gmail.com>
Date:	Wed, 31 Mar 2010 11:37:47 +0530
From:	kishore kadiyala <kishorek.kadiyala@...il.com>
To:	Madhusudhan <madhu.cr@...com>
Cc:	tony@...mide.com, svenkatr@...com, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, jarkko.lavinen@...ia.com
Subject: [PATCH-V2] OMAP: Fix for bus width which improves SD card's 
	peformance.

This patch improves low speeds for SD cards.
OMAP-MMC controller's can support maximum bus width of '8'.
when bus width is mentioned as "8" in controller data,the SD
stack will check whether bus width is "4" and if not it will
set bus width to "1" and there by degrading performance.
This patch fixes the issue and improves the performance of
SD cards.

Signed-off-by: Kishore Kadiyala <kishore.kadiyala@...com>
Signed-off-by: Venkatraman S <svenkatr@...com>
Acked-by: Madhusudhan Chikkature <madhu.cr@...com>

---
In V2 : Appended Signed-off by Venkat and Ack by Madhu

 Here are my experiment numbers, on a Class 6 SDHC card:
 Read peformance is increased by 220%
 Write Performance is increased by 52%

 drivers/mmc/host/omap_hsmmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 83f0aff..8c97c22 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2092,7 +2092,7 @@ static int __init omap_hsmmc_probe(struct
                   MMC_CAP_WAIT_WHILE_BUSY;

      if (mmc_slot(host).wires >= 8)
-               mmc->caps |= MMC_CAP_8_BIT_DATA;
+               mmc->caps |= (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA);
      else if (mmc_slot(host).wires >= 4)
              mmc->caps |= MMC_CAP_4_BIT_DATA;

--
1.6.3.3


On Thu, Feb 11, 2010 at 11:04 PM, Madhusudhan <madhu.cr@...com> wrote:
>
>
>> -----Original Message-----
>> From: kishore kadiyala [mailto:kishore.kadiyala@...com]
>> Sent: Thursday, February 11, 2010 8:20 AM
>> To: linux-omap@...r.kernel.org; linux-kernel@...r.kernel.org
>> Cc: jarkko.lavinen@...ia.com; madhu.cr@...com
>> Subject: [PATCH] OMAP: Fix for bus width which improves SD card's
>> peformance.
>>
>> This patch improves low speeds for SD cards.
>> OMAP-MMC controller's can support maximum bus width of '8'.
>> when bus width is mentioned as "8" in controller data,the SD
>> stack will check whether bus width is "4" and if not it will
>> set bus width to "1" and there by degrading peformance.
>> This patch fixes the issue and improves the performance of
>> SD cards.
>>
>> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@...com>
>
> ACK
>
> Acked-by: Madhusudhan Chikkature <madhu.cr@...com>
>
>> ---
>>  Here are my experiment numbers, on a Class 6 SDHC card:
>>  Read peformance is increased by 220%
>>  Write Performance is increased by 52%
>>
>>  drivers/mmc/host/omap_hsmmc.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
>> index 83f0aff..8c97c22 100644
>> --- a/drivers/mmc/host/omap_hsmmc.c
>> +++ b/drivers/mmc/host/omap_hsmmc.c
>> @@ -2092,7 +2092,7 @@ static int __init omap_hsmmc_probe(struct
>> platform_device
>> *pdev)
>>                    MMC_CAP_WAIT_WHILE_BUSY;
>>
>>       if (mmc_slot(host).wires >= 8)
>> -             mmc->caps |= MMC_CAP_8_BIT_DATA;
>> +             mmc->caps |= (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA);
>>       else if (mmc_slot(host).wires >= 4)
>>               mmc->caps |= MMC_CAP_4_BIT_DATA;
>>
>> --
>> 1.6.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/