linux-kernel - Re: [RFC 0/9] BKL conversion in TTY drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201003310957.03025.arnd@arndb.de>
Date:	Wed, 31 Mar 2010 09:57:02 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	LKML <linux-kernel@...r.kernel.org>, Greg KH <gregkh@...e.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	John Kacur <jkacur@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [RFC 0/9] BKL conversion in TTY drivers

On Wednesday 31 March 2010 00:37:59 Alan Cox wrote:
> 
> > This means we are still safe, because there is no code
> > left that the new BTM fails to serialize with.
> 
> We hope. I'm currently poking at sorting out the locking properly and
> quite frankly the locking rules for the current tty reference have me
> baffled. It clearly works as we've not got a pile of dumps in the
> bugzilla tree but its also quite a mystery *how*.

Yes, that's why I didn't even attempt to find out why the BKL is
in some places or what it protects, but only changed the way it gets
taken and released.

We also have empirical evidence that turning the BKL into a semaphore
doesn't make the code fall apart, so I'm assuming that the mutex based
implementation with the explicit release-when-blocking instead of
implicit release-when-sleeping is still equivalent.

Are you more worried that the interface conversion (patches 1-8)
can introduce bugs and make your life harder, or that the mutex
based implementation from patch 9 causes problems that were previously
hidden by other bugs?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/