linux-kernel - Re: [PATCH] audit: Reactive rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1870478057.299001270060565969.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
Date:	Wed, 31 Mar 2010 14:36:05 -0400 (EDT)
From:	Miloslav Trmac <mitr@...hat.com>
To:	Juraj Hlista <juro.hlista@...il.com>
Cc:	linux-audit@...hat.com, linux-kernel@...r.kernel.org,
	viro@...iv.linux.org.uk, sgrubb@...hat.com
Subject: Re: [PATCH] audit: Reactive rules

Hello,
----- "Juraj Hlista" <juro.hlista@...il.com> wrote:
> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> @@ -415,7 +424,8 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
> -	int i;
> +	int i, j = 0;
> +	int k;
> @@ -425,7 +435,7 @@ static struct audit_entry
> *audit_data_to_entry(struct audit_rule_data *data,
>  	for (i = 0; i < data->field_count; i++) {
> -		struct audit_field *f = &entry->rule.fields[i];
> +		struct audit_field *f = &entry->rule.fields[i - j];
It would be more clear to have a "source index" (used for "data"), and a "destination index" (used for entry->rule.fields); "j" is currently a difference between the two.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/