linux-kernel - Re: [Stable-review] [007/116] tg3: Fix 5906 transmit hangs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100331212309.GB16663@xw6200.broadcom.net>
Date:	Wed, 31 Mar 2010 14:23:09 -0700
From:	"Matt Carlson" <mcarlson@...adcom.com>
To:	"Greg KH" <gregkh@...e.de>
cc:	"Chuck Ebbert" <cebbert@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...nel.org" <stable@...nel.org>,
	"Matthew Carlson" <mcarlson@...adcom.com>,
	"David S. Miller" <davem@...emloft.net>,
	"Mike Pagano" <mpagano@...too.org>,
	"Michael Chan" <mchan@...adcom.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"stable-review@...nel.org" <stable-review@...nel.org>,
	"alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>
Subject: Re: [Stable-review] [007/116] tg3: Fix 5906 transmit hangs

On Wed, Mar 31, 2010 at 01:39:26PM -0700, Greg KH wrote:
> On Tue, Mar 30, 2010 at 09:15:22PM -0400, Chuck Ebbert wrote:
> > On Tue, 30 Mar 2010 15:54:45 -0700
> > Greg KH <gregkh@...e.de> wrote:
> > 
> > > 2.6.32-stable review patch.  If anyone has any objections, please let
> > > us know.
> > > 
> > > ------------------
> > > 
> > > From: Matt Carlson <mcarlson@...adcom.com>
> > > 
> > > This is a resubmit backport of commit
> > > 92c6b8d16a36df3f28b2537bed2a56491fb08f11 to kernel version 2.6.32.
> > > The gentoo bug report can be found at
> > > https://bugs.gentoo.org/show_bug.cgi?id=301091. Thanks to Matt
> > > Carlson for his assistance and working me to fix a regression caused
> > > by the initial patch.  The original description is as follows:
> > > 
> > 
> > I think these two patches should be used instead, as they fix the
> > bug without needing backports and keep the driver closer to upstream:
> > 
> > 0e1406dd404ce55dbe8d68b4b5e2aed7e5c75fdb
> > "tg3: Assign flags to fixes in start_xmit_dma_bug"
> > 
> > 92c6b8d16a36df3f28b2537bed2a56491fb08f11
> > "tg3: Fix 5906 transmit hangs"
> 
> I don't know, I'll defer to Matt here, this patch has gone in and out of
> the stable queue for a while now as he and some users have tested and
> had problems lots of times...
> 
> Matt?

I'm O.K. with either path.  I supported Mike's patch because it was
minimal.  (All the bugs should be shaken out by now.)  If that isn't a
goal, then I guess I'd rather rubber stamp my own implementation.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/