linux-kernel - Re: Config NO_BOOTMEM breaks my amd64 box

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BB3C9B0.4000205@kernel.org>
Date:	Wed, 31 Mar 2010 15:16:16 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	James Morris <jmorris@...ei.org>, "H. Peter Anvin" <hpa@...or.com>,
	linux-kernel@...r.kernel.org, airlied@...ux.ie
Subject: Re: Config NO_BOOTMEM breaks my amd64 box

On 03/31/2010 03:13 PM, Ingo Molnar wrote:
> 
> * Yinghai Lu <yinghai@...nel.org> wrote:
> 
>> --- linux-2.6.orig/arch/x86/mm/init_32.c
>> +++ linux-2.6/arch/x86/mm/init_32.c
>> @@ -875,7 +875,12 @@ void __init mem_init(void)
>>  	BUG_ON(!mem_map);
>>  #endif
>>  	/* this will put all low memory onto the freelists */
>> +#if defined(CONFIG_NO_BOOTMEM) && defined(MAX_NUMNODES)
>> +	/* In case some 32bit systems don't have RAM installed on node0 */
>> +        totalram_pages += free_all_memory_core_early(MAX_NUMNODES);
> 
> (Note: tab whitespace damage)
> 
>> +#else
>>  	totalram_pages += free_all_bootmem();
> 
> So we get into this branch if CONFIG_NO_BOOTMEM is enabled but MAX_NUMNODES is 
> not defined? Doesnt look right.

yes. 

free_all_bootmem() will call
free_all_memory_core_early(NODE_DATA(0)->node_id);

Thanks

Yinghai Lu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/