linux-kernel - linux-next: build warning after merge of the cifs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20100401115059.d0bdb1bd.sfr@canb.auug.org.au>
Date:	Thu, 1 Apr 2010 11:50:59 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Steve French <smfrench@...il.com>,
	<linux-cifs-client@...ts.samba.org>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Suresh Jayaraman <sjayaraman@...e.de>
Subject: linux-next: build warning after merge of the cifs tree

Hi Steve,

After merging the cifs tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

fs/cifs/cifssmb.c: In function 'CIFSSMBWrite':
fs/cifs/cifssmb.c:1516: warning: suggest explicit braces to avoid ambiguous 'else'

Introduced by commit 5702f749ee6645f70412cfe6408503a735366ffe ("cifs:
initialize nbytes at the beginning of CIFSSMBWrite()").

The cFYI() macro that is invoked in the (unbraced) if clause contains an
if statement ...  so this warning actually indicates a bug.  Those
debugging macros look like a real mess ...

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped