linux-kernel - Re: linux-next: build failure after merge of the final tree (hid tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1004010817420.8345@pobox.suse.cz>
Date:	Thu, 1 Apr 2010 08:18:43 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bruno Prémont <bonbons@...ux-vserver.org>
Subject: Re: linux-next: build failure after merge of the final tree (hid
 tree related)

On Thu, 1 Apr 2010, Stephen Rothwell wrote:

> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/hid/hid-picolcd.c: In function 'picolcd_debug_reset_write':
> drivers/hid/hid-picolcd.c:1343: error: implicit declaration of function 'copy_from_user'
> drivers/hid/hid-picolcd.c: In function 'picolcd_debug_eeprom_read':
> drivers/hid/hid-picolcd.c:1407: error: implicit declaration of function 'copy_to_user'
> 
> Caused by commit 9bbf2b98ba11d00bd73e3254e15cfe17ccaff6ba ("HID: add
> experimental access to PicoLCD device's EEPROM and FLASH").  Using copy_
> {to,from}_user requires the include of linux/uaccess.h.
> 
> I have reverted that commit for today.

Hmm, on which arch did this bomb out? I wonder why it is building fine for 
me.

Anyway, I have added the include, as it is obviously correct(tm), thanks 
for reporting it.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/