lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20100401010706.GA2069@localhost.localdomain>
Date:	Wed, 31 Mar 2010 21:07:06 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Brandon Philips <brandon@...p.org>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	michael.s.gilbert@...il.com, davem@...emeloft.net,
	romieu@...zoreil.com, eric.dumazet@...il.com
Subject: Re: [PATCH] r8169: offical fix for CVE-2009-4537 (overlength frame
 DMAs)

On Wed, Mar 31, 2010 at 05:24:50PM -0700, Brandon Philips wrote:
> On 12:03 Mon 29 Mar 2010, Neil Horman wrote:
> > Signed-off-by: Neil Horman <nhorman@...hat.com>
> 
> Cc: stable@...nel.org?
> Tested-by: Brandon Philips <bphilips@...e.de>
> 
> > +	if (max_frame != 16383)
> > +		printk(KERN_WARNING "WARNING! Changing of MTU on this NIC"
> > +			"May lead to frame reception errors!\n");
> 
> This needs a space to look right. You might as well add the PFX too:
> 
> 		printk(KERN_WARNING PFX "WARNING! Changing of MTU on this "
> 			"NIC may lead to frame reception errors!\n");
> 
> Thanks Neil.
> 
> Cheers,
> 
> 	Brandon
> 
Daves already merged my patch, but I'll submit a cleanup patch shortly to take
care of this.
Thanks!
Neil

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ