linux-kernel - Re: [RFC 0/9] BKL conversion in TTY drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100401151756.5e329014@lxorguk.ukuu.org.uk>
Date:	Thu, 1 Apr 2010 15:17:56 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Greg KH <gregkh@...e.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	John Kacur <jkacur@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [RFC 0/9] BKL conversion in TTY drivers

> Greg, are you ok with merging these TTY patches in your tree for 2.6.35
> then? There will be at least one more respin of it for minor changes
> and anything that comes up during testing, but it's essentially what I
> posted here.

Can we please wait a bit with the tty bits. I'm slowing picking through
the job properly and there are a lot of low hanging fruit to clean up at
the driver end of things that is best done before we complicate the core
stuff.

I'll try and get some patches posted ASAP for those but for example most
of the BKL use in the drivers/char tty drivers is now done, and those
remaining are almost all in code that we should simply drop as its been
marked broken/obsolete anyway.

Arnd there is another problem I noticed in your changes - the ppp stuff
is not tty locking, its some kind of driver/network locking and I don't
claim to understand what is going on.

Another one that wants attention from someone brave is selection.c - that
isn't tty locking dependant either but relies on the callers happening
(mostly but not always!) to call it with the BKL held.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/