linux-kernel - Re: [PATCH] proc: Report file name on detected read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201004011641.58462.elendil@planet.nl>
Date:	Thu, 1 Apr 2010 16:41:56 +0200
From:	Frans Pop <elendil@...net.nl>
To:	Jan Kiszka <jan.kiszka@...mens.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	adobriyan@...il.com, helight.xu@...il.com, viro@...iv.linux.org.uk
Subject: Re: [PATCH] proc: Report file name on detected read_proc overflow

Jan Kiszka wrote:
> -                                      "proc_file_read: Apparent buffer overflow!\n");
> +                                      "proc_file_read: Apparent buffer "
> +                                      "overflow reading \"%s\"!\n",
> +                                      file->f_path.dentry->d_name.name);

I think it would be good to keep "overflow" on the first line as that
may be what people will grep the source for. And maybe use single quotes
around the file name. So:

+                                      "proc_file_read: Apparent buffer overflow "
+                                      "reading '%s'!\n",
+                                      file->f_path.dentry->d_name.name);

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/