linux-kernel - Re: [patch] thermal: make lockdep happy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1270086290.24064.4466.camel@rzhang1-desktop>
Date:	Thu, 01 Apr 2010 09:44:50 +0800
From:	Zhang Rui <rui.zhang@...el.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	"casteyde.christian@...e.fr" <casteyde.christian@...e.fr>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Brown, Len" <len.brown@...el.com>,
	Matthew Garrett <mjg@...hat.com>,
	Frans Pop <elendil@...net.nl>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [patch] thermal: make lockdep happy

On Thu, 2010-04-01 at 01:09 +0800, Dan Carpenter wrote:
> Hi Christian,
> 
> Can you test this patch?
> 
> I wrote this to address bugzilla bug:
> 	https://bugzilla.kernel.org/show_bug.cgi?id=15504
> 	BUG: key ffff88004c3811e0 not in .data! occured in lockdep.c
> 
> We now have to call sysfs_attr_init() for dynamically allocated sysfs 
> attributes or lockdep complains.
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>
Acked-by: Zhang Rui <rui.zhang@...el.com>

> 
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 5066de5..d4fec47 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -725,6 +725,7 @@ int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz,
>  		goto release_idr;
>  
>  	sprintf(dev->attr_name, "cdev%d_trip_point", dev->id);
> +	sysfs_attr_init(&dev->attr.attr);
>  	dev->attr.attr.name = dev->attr_name;
>  	dev->attr.attr.mode = 0444;
>  	dev->attr.show = thermal_cooling_device_trip_point_show;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/