linux-kernel - Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BB4DCCA.5030907@ladisch.de>
Date:	Thu, 01 Apr 2010 19:50:02 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Alex Deucher <alexdeucher@...il.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux PCI <linux-pci@...r.kernel.org>,
	Greg KH <gregkh@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	dri-devel@...ts.sourceforge.net, stable@...nel.org
Subject: Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780

Linus Torvalds wrote:
> On Thu, 1 Apr 2010, Alex Deucher wrote:
> > Clemems' "PCI quirk: RS780/RS880: disable MSI completely" patch is the
> > right approach I think.  Note that it's only devices hung off the int
> > gfx pci to pci bridge that have broken MSI (gfx and audio).  MSI works
> > fine on the PCIE slots.  I have a similar patch for rs400 chips on bug
> > 15626:
> > https://bugzilla.kernel.org/show_bug.cgi?id=15626
> 
> Hmm. Does 'pci_msi_enable' only cover regular PCI devices? Or will that 
> pci_no_msi() quirk disable MSI for PCIE too?

A quirk that used pci_no_msi() would disable all MSI for all devices.
However, these patches (and that in bug 15626) use PCI_BUS_FLAGS_NO_MSI
so that only the internal GPU devices are affected.

That "completely" in my patch title should better read "unconditionally".


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/