linux-kernel - Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201004012228.06938.rjw@sisk.pl>
Date:	Thu, 1 Apr 2010 22:28:06 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Alex Deucher <alexdeucher@...il.com>
Cc:	Clemens Ladisch <clemens@...isch.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	Greg KH <gregkh@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	dri-devel@...ts.sourceforge.net, stable@...nel.org,
	Dave Airlie <airlied@...il.com>
Subject: Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3)

On Thursday 01 April 2010, Alex Deucher wrote:
> On Thu, Apr 1, 2010 at 2:36 AM, Clemens Ladisch <clemens@...isch.de> wrote:
> > Alex Deucher wrote:
> >> On Wed, Mar 31, 2010 at 9:13 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> >>> On Tuesday 30 March 2010, Rafael J. Wysocki wrote:
> >>>> >       PCI quirk: RS780/RS880: work around missing MSI initialization
> >>>>
> >>>> This one (commit a5ee4eb7541) broke OpenGL acceleration on my new test box
> >>>> which happens to have a RS780.
> >
> > So it's better to disable MSI unconditionally.
> >
> > Rafael, can you check if MSI works for the HDMI audio device?
> > (I'd guess it doesn't.)
> >
> >> I also have the attached patch queued in via Dave's tree to disable
> >> MSI on all IGP chips for the time being.
> >
> > This disables MSI only for the graphics device.  I'd prefer to have
> > the quirk on its bridge so that MSI gets disabled for the HDMI audio
> > device too, to avoid having to duplicate this quirk in the snd-hda-intel
> > driver.
> >
> > ==========
> >
> > PCI quirk: RS780/RS880: disable MSI completely
> >
> > The missing initialization of the nb_cntl.strap_msi_enable does not seem
> > to be the only problem that prevents MSI, so that quirk is not
> > sufficient to enable MSI on all machines.  To be safe, unconditionally
> > disable MSI for the internal graphics and HDMI audio on these chipsets.
> >
> > Signed-off-by: Clemens Ladisch <clemens@...isch.de>
> 
> Works fine here.
> 
> Tested-by: Alex Deucher <alexdeucher@...il.com>

Unfortunately it doesn't work for me without the

if ((rdev->family >= CHIP_RV380) &&
            (!(rdev->flags & RADEON_IS_IGP)))

radeon quirk.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/