linux-kernel - Re: [PATCH -v2] ibft, x86: Change reserve_ibft_region() to find_ibft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <n2n86802c441004011500z441e91d8nc4453d6e85c82d5@mail.gmail.com>
Date:	Thu, 1 Apr 2010 15:00:05 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Peter Jones <pjones@...hat.com>,
	Konrad Rzeszutek Wilk <konrad@...nel.org>,
	Jan Beulich <jbeulich@...ell.com>
Subject: Re: [PATCH -v2] ibft, x86: Change reserve_ibft_region() to 
	find_ibft_region()

On Thu, Apr 1, 2010 at 2:54 PM, Randy Dunlap <randy.dunlap@...cle.com> wrote:
> On Thu, 01 Apr 2010 14:32:43 -0700 Yinghai Lu wrote:
>
>>
>>
>> So arch code could decide the way to reserve the ibft.
>>
>> And We should reserve ibft as early as possible, instead of BOOTMEM stage,
>> in case the table is in RAM range and is not reserved by BIOS.
>>
>> move that just sfter find_smp_config()
>>
>> Also when CONFIG_NO_BOOTMEM=y, We will not have reserve_bootmem() anymorea
>>
>> -v2: fix typo about ibft pointed by Konrad Rzeszutek Wilk <konrad@...nok.org>
>
>
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>> Cc: Pekka Enberg <penberg@...helsinki.fi>
>> Cc: Peter Jones <pjones@...hat.com>
>> Cc: Konrad Rzeszutek Wilk <konrad@...nel.org>
>> CC: Jan Beulich <jbeulich@...ell.com>
>>
>> ---
>>  arch/x86/kernel/setup.c            |   14 ++++++++++++--
>>  drivers/firmware/iscsi_ibft_find.c |   11 ++++++++---
>>  include/linux/iscsi_ibft.h         |    8 ++++++--
>>  3 files changed, 26 insertions(+), 7 deletions(-)
>>
>> Index: linux-2.6/arch/x86/kernel/setup.c
>> ===================================================================
>> --- linux-2.6.orig/arch/x86/kernel/setup.c
>> +++ linux-2.6/arch/x86/kernel/setup.c
>> @@ -608,6 +608,16 @@ static int __init setup_elfcorehdr(char
>>  early_param("elfcorehdr", setup_elfcorehdr);
>>  #endif
>>
>> +static __init void reserve_ibft_region(void)
>> +{
>> +     unsigned long addr, size = 0;
>> +
>> +     addr = find_ibft_region(&size);
>> +
>> +     if (size)
>> +             reserve_early_overlap_ok(addr, addr + size, "ibft");
>
>        where is the correction?

-v1 has

 +     if (size)
 +             reserve_early_overlap_ok(addr, addr + size, "ifbt");

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/