| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100402162704.GM8010@sortiz.org> Date: Fri, 2 Apr 2010 18:27:05 +0200 From: Samuel Ortiz <sameo@...ux.intel.com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH] mfd: Improve WM831x AUXADC completion handling On Fri, Apr 02, 2010 at 04:31:03PM +0100, Mark Brown wrote: > Currently completion of WM831x AUXADC conversions is monitored by > checking for convertor enable. Due to the mechanism used to ensure > data corruption is avoided when reading AUXADC data there may under > heavy I/O be a window where this bit has cleared but the conversion > results have not been updated. Data availability is only guaranteed > after the AUXADC data interrupt has been asserted. > > Avoid this by always using the interrupt to detect completion. If the > chip IRQ is not set up then we poll the IRQ status register for up to > 5ms. If it is set up then we rely on the data done interrupt with a > vastly increased timeout, failing the conversion if the interrupt is > not generated. > > This also saves a register read when using interrupts. > > Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com> Applied to my for-next branch, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists