linux-kernel - Re: BUG: null pointer deref in dmar_ir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1270232913.2870.60.camel@sbs-t61.sc.intel.com>
Date:	Fri, 02 Apr 2010 11:28:33 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"Jan.Grossmann@...lnet.net" <Jan.Grossmann@...lnet.net>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"jbarnes@...tuousgeek.org" <jbarnes@...tuousgeek.org>,
	"Woodhouse, David" <david.woodhouse@...el.com>,
	"Han, Weidong" <weidong.han@...el.com>,
	"Song, Youquan" <youquan.song@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"stable@...nel.org" <stable@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: BUG: null pointer deref in dmar_ir_support

On Fri, 2010-04-02 at 11:20 -0700, Ingo Molnar wrote:
> * Suresh Siddha <suresh.b.siddha@...el.com> wrote:
> 
> > @@ -1640,8 +1640,10 @@ int __init APIC_init_uniprocessor(void)
> >  	}
> >  #endif
> >  
> > +#ifndef CONFIG_SMP
> >  	enable_IR_x2apic();
> >  	default_setup_apic_routing();
> > +#endif
> 
> Instead of adding yet another ugly #ifdef please hide these details properly, 
> by making enable_IR_x2apic() and default_setup_apic_routing() a NOP on !SMP.

Ingo, These are not nops on !SMP. We should call these functions from
APIC_init_uniprocessor() only if it is a UP kernel. For SMP kernel they
are called from some where else.

With the current code, on SMP and with non SMP motherboard we were
calling these routines twice which cause problem.

I wanted to keep the patch simple for urgent/backport. I will clean this
by restructuring the init code for 2.6.35

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/