linux-kernel - Re: [PATCH 3/4] Revert "x86: disable IOMMUs on kernel crash"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100403172224.GO24846@8bytes.org>
Date:	Sat, 3 Apr 2010 19:22:24 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Chris Wright <chrisw@...s-sol.org>
Cc:	Joerg Roedel <joerg.roedel@....com>, nhorman@...hat.com,
	nhorman@...driver.com, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org, hbabu@...ibm.com,
	iommu@...ts.linux-foundation.org, ebiederm@...ssion.com,
	vgoyal@...hat.com
Subject: Re: [PATCH 3/4] Revert "x86: disable IOMMUs on kernel crash"

On Fri, Apr 02, 2010 at 06:27:54PM -0700, Chris Wright wrote:
> This effectively reverts commit 61d047be99757fd9b0af900d7abce9a13a337488.
> 
> Disabling the IOMMU can potetially allow DMA transactions to
> complete without being translated.  Leave it enabled, and allow
> crash kernel to do the IOMMU reinitialization properly.
> 
> Cc: Joerg Roedel <joerg.roedel@....com>
> Cc: Eric Biederman <ebiederm@...ssion.com>
> Cc: Neil Horman <nhorman@...driver.com>
> Cc: Vivek Goyal <vgoyal@...hat.com>
> Signed-off-by: Chris Wright <chrisw@...s-sol.org>
> ---
>  arch/x86/kernel/crash.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> --- a/arch/x86/kernel/crash.c
> +++ b/arch/x86/kernel/crash.c
> @@ -27,7 +27,6 @@
>  #include <asm/cpu.h>
>  #include <asm/reboot.h>
>  #include <asm/virtext.h>
> -#include <asm/x86_init.h>
>  
>  #if defined(CONFIG_SMP) && defined(CONFIG_X86_LOCAL_APIC)
>  
> @@ -103,10 +102,5 @@ void native_machine_crash_shutdown(struc
>  #ifdef CONFIG_HPET_TIMER
>  	hpet_disable();
>  #endif
> -
> -#ifdef CONFIG_X86_64
> -	x86_platform.iommu_shutdown();
> -#endif
> -
>  	crash_save_cpu(regs, safe_smp_processor_id());

Hmm, I think for this we need to change the gart code too and disable
the gart before its initialization runs to not re-introduce issues fixed
in commit bc2cea6a34fdb30f118ec75db39a46a191870607, no?

	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/