linux-kernel - Re: [PATCH] Fix key f70f4b50 not in .data in thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 04 Apr 2010 20:17:43 -0400 (EDT)
From:	Len Brown <lenb@...nel.org>
To:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:	Wolfram Sang <w.sang@...gutronix.de>, Greg KH <gregkh@...e.de>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Lin Ming <ming.m.lin@...el.com>
Subject: Re: [PATCH] Fix key f70f4b50 not in .data in thermal_sys V2

applied

thanks,
Len Brown, Intel Open Source Technology Center

On Mon, 22 Mar 2010, Sergey Senozhatsky wrote:

> 
> Initialize sysfs attributes before device_create_file call.
> 
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> ---
> 
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 5066de5..ecb181d 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -505,6 +505,7 @@ thermal_add_hwmon_sysfs(struct thermal_zone_device *tz)
>  	tz->temp_input.attr.attr.name = tz->temp_input.name;
>  	tz->temp_input.attr.attr.mode = 0444;
>  	tz->temp_input.attr.show = temp_input_show;
> +	sysfs_attr_init(&tz->temp_input.attr.attr);
>  	result = device_create_file(hwmon->device, &tz->temp_input.attr);
>  	if (result)
>  		goto unregister_hwmon_device;
> @@ -517,6 +518,7 @@ thermal_add_hwmon_sysfs(struct thermal_zone_device *tz)
>  			tz->temp_crit.attr.attr.name = tz->temp_crit.name;
>  			tz->temp_crit.attr.attr.mode = 0444;
>  			tz->temp_crit.attr.show = temp_crit_show;
> +			sysfs_attr_init(&tz->temp_crit.attr.attr);
>  			result = device_create_file(hwmon->device,
>  						    &tz->temp_crit.attr);
>  			if (result)
> @@ -725,6 +727,7 @@ int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz,
>  		goto release_idr;
>  
>  	sprintf(dev->attr_name, "cdev%d_trip_point", dev->id);
> +	sysfs_attr_init(&dev->attr.attr);
>  	dev->attr.attr.name = dev->attr_name;
>  	dev->attr.attr.mode = 0444;
>  	dev->attr.show = thermal_cooling_device_trip_point_show;
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/