linux-kernel - RE: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 Apr 2010 12:19:29 -0500
From:	"Madhusudhan" <madhu.cr@...com>
To:	<me@...ipebalbi.com>,
	"'kishore kadiyala'" <kishorek.kadiyala@...il.com>
Cc:	"'Vimal Singh'" <vimal.newwork@...il.com>, <tony@...mide.com>,
	<svenkatr@...com>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <jarkko.lavinen@...ia.com>
Subject: RE: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance.



> -----Original Message-----
> From: Felipe Balbi [mailto:me@...ipebalbi.com]
> Sent: Monday, April 05, 2010 11:49 AM
> To: kishore kadiyala
> Cc: Madhusudhan; Vimal Singh; tony@...mide.com; svenkatr@...com; linux-
> omap@...r.kernel.org; linux-kernel@...r.kernel.org;
> jarkko.lavinen@...ia.com
> Subject: Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's
> peformance.
> 
> Hi,
> 
> On Mon, Apr 05, 2010 at 06:26:16PM +0530, kishore kadiyala wrote:
> > @@ -2091,9 +2091,9 @@ static int __init omap_hsmmc_probe(struct
> >  	mmc->caps |= MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED |
> >  		     MMC_CAP_WAIT_WHILE_BUSY;
> >
> > -	if (mmc_slot(host).wires >= 8)
> > -		mmc->caps |= MMC_CAP_8_BIT_DATA;
> > -	else if (mmc_slot(host).wires >= 4)
> > +	if (mmc_slot(host).wires == 8)
> > +		mmc->caps |= (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA);
> > +	else if (mmc_slot(host).wires == 4)
> >  		mmc->caps |= MMC_CAP_4_BIT_DATA;
> 
> I believe it would be enough to just remove the 'else', so the code
> would look like:
> 
> if (mmc_slot(host).wires >= 8)
> 	mmc->caps |= MMC_CAP_8_BIT_DATA;
> if (mmc_slot(host).wires >= 4)

Since the first if command already checks for the 8-bit the second check
like >= 4 is definitely not readable in my opinion.

Functionally do you see anything wrong with this patch??

> 	mmc->caps |= MMC_CAP_4_BIT_DATA;
> 
> --
> balbi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/