linux-kernel - Bad watchdog ioctl definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <s2g6a4b170b1004050239ga41e5496r1e416b755f655a0a@mail.gmail.com>
Date:	Mon, 5 Apr 2010 10:39:25 +0100
From:	James Hogan <james@...anarts.com>
To:	Wim Van Sebroeck <wim@...ana.be>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thierry Reding <thierry.reding@...onic-design.de>,
	linux-kernel@...r.kernel.org
Subject: Bad watchdog ioctl definitions

Hi,

I've noticed that some of the ioctl definitions in
include/linux/watchdog.h are incorrect, for example:

#define WDIOC_SETOPTIONS        _IOR(WATCHDOG_IOCTL_BASE, 4, int)
This is a write ioctl so should be _IOW

#define WDIOC_KEEPALIVE         _IOR(WATCHDOG_IOCTL_BASE, 5, int)
I think this should just be _IO since the argument is ignored anyway

>From a quick grep, mpcore_wdt appears to be the only watchdog driver
in drivers/watchdog that uses _IOC_DIR on the ioctl number, which
breaks the SETOPTIONS ioctl on this driver.

Is it usually even possible to change ioctl numbers for compatibility?
What's the usual process?

Cheers
-- 
James Hogan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/