linux-kernel - Re: [GIT PULL] break implicit percpu.h -> slab.h dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100406092523.GA30270@elte.hu>
Date:	Tue, 6 Apr 2010 11:25:23 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Tejun Heo <tj@...nel.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [GIT PULL] break implicit percpu.h -> slab.h dependency


* Tejun Heo <tj@...nel.org> wrote:

>   git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git slabh
> 
> This is rather unusual pull request at this stage in -rc cycles but
> given the mostly trivial nature and massive size of this change, I
> think it would be beneficial to merge this while the tree isn't
> changing too rapidly and as early as possible so that further
> breakages aren't introduced.

FYI, -tip testing found a build breakage with your changes:

 drivers/base/node.c:373: error: implicit declaration of function 'kmalloc'
 drivers/base/node.c:377: error: implicit declaration of function 'kfree'

The fix is below. Since my first test today triggered a build failure i'd 
expect there to be more - i'll send all subsequent fixes to this thread.

Thanks,

	Ingo

Index: linux2/drivers/base/node.c
===================================================================
--- linux2.orig/drivers/base/node.c
+++ linux2/drivers/base/node.c
@@ -16,6 +16,7 @@
 #include <linux/device.h>
 #include <linux/swap.h>
 #include <linux/gfp.h>
+#include <linux/slab.h>
 
 static struct sysdev_class_attribute *node_state_attrs[];
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/