linux-kernel - Re: [PATCH 03/11] drivers/usb/wusbcore/wusbhc.h: Remove unused dev_info from struct wusb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BBB0167.2040903@ru.mvista.com>
Date:	Tue, 06 Apr 2010 13:39:51 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Joe Perches <joe@...ches.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	David Vrabel <david.vrabel@....com>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/11] drivers/usb/wusbcore/wusbhc.h: Remove unused dev_info
 from struct wusb_port

Hello.

Joe Perches wrote:

> There is a macro called dev_info that prints struct device specific
> information.  Having variables with the same name can be confusing and
> prevents conversion of the macro to a function.
>
> Rename the existing dev_info variables to something else in preparation
> to converting the dev_info macro to a function.
>   

   You're not renaming the variable in this case, you're removing a field.

> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/usb/wusbcore/wusbhc.h |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/wusbcore/wusbhc.h b/drivers/usb/wusbcore/wusbhc.h
> index 759cda5..dffda29 100644
> --- a/drivers/usb/wusbcore/wusbhc.h
> +++ b/drivers/usb/wusbcore/wusbhc.h
> @@ -185,15 +185,6 @@ struct wusb_port {
>   *
>   *                 Read/Write protected by @mutex
>   *
> - * @dev_info       This array has ports_max elements. It is used to
> - *                 give the HC information about the WUSB devices (see
> - *                 'struct wusb_dev_info').
> - *
> - *	           For HWA we need to allocate it in heap; for WHCI it
> - *                 needs to be permanently mapped, so we keep it for
> - *                 both and make it easy. Call wusbhc->dev_info_set()
> - *                 to update an entry.
> - *
>   * @ports_max	   Number of simultaneous device connections (fake
>   *                 ports) this HC will take. Read-only.
>   *
> @@ -259,7 +250,6 @@ struct wusbhc {
>  	struct mutex mutex;			/* locks everything else */
>  	u16 cluster_id;				/* Wireless USB Cluster ID */
>  	struct wusb_port *port;			/* Fake port status handling */
> -	struct wusb_dev_info *dev_info;		/* for Set Device Info mgmt */
>  	u8 ports_max;
>  	unsigned active:1;			/* currently xmit'ing MMCs */
>  	struct wuie_keep_alive keep_alive_ie;	/* protected by mutex */
>   

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/