linux-kernel - Re: [GIT PULL] break implicit percpu.h -> slab.h dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100406095012.GA23593@elte.hu>
Date:	Tue, 6 Apr 2010 11:50:12 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Tejun Heo <tj@...nel.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [GIT PULL] break implicit percpu.h -> slab.h dependency


* Tejun Heo <tj@...nel.org> wrote:

> Hello, Ingo.
> 
> On 04/06/2010 06:25 PM, Ingo Molnar wrote:
> > FYI, -tip testing found a build breakage with your changes:
> > 
> >  drivers/base/node.c:373: error: implicit declaration of function 'kmalloc'
> >  drivers/base/node.c:377: error: implicit declaration of function 'kfree'
> 
> These are NODEMASK_ALLOC() and NODEMASK_FREE() macros which become
> kmalloc/kfree() iff NODES_SHIFT > 8.  I'll grep for these macros and
> commit a proper fix.
> 
> > The fix is below. Since my first test today triggered a build failure i'd 
> > expect there to be more - i'll send all subsequent fixes to this thread.
> 
> Thanks.  Much appreciated.

It's looking pretty good so far with about a dozen tests passed. Thanks for 
doing this transition so carefully!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/