linux-kernel - Re: [PATCH]: REPOST cleanup debug message in init_kstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4BBB3BB1.4070501@redhat.com>
Date:	Tue, 06 Apr 2010 09:48:33 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	Prarit Bhargava <prarit@...hat.com>
CC:	yinghai@...nel.org, akpm@...ux-foundation.org, mingo@...e.hu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: REPOST cleanup debug message in init_kstat_irqs()

Whoops... Subject should have been REPOST cleanup debug message in 
irq_to_desc_alloc_node()

Sorry 'bout that.

P.

Prarit Bhargava wrote:
> [Sending to a wider audience this time, cc'ing Andrew and Ingo directly]
>
> Clean up debug messages in irq_to_desc_alloc_node().
>
> This debug message can result in valid output like
>
> 	alloc irq_desc for 73 on node -1
>
> which looks like alot like an error message.
>
> This debug statement has been in the kernel for about a year, so I think it is
> safe to remove it and report the irq and node in the error case instead.
>
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>
>
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index 17c71bb..5c3e38e 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -224,9 +224,10 @@ struct irq_desc * __ref irq_to_desc_alloc_node(unsigned int irq, int node)
>  	else
>  		desc = alloc_bootmem_node(NODE_DATA(node), sizeof(*desc));
>  
> -	printk(KERN_DEBUG "  alloc irq_desc for %d on node %d\n", irq, node);
>  	if (!desc) {
> -		printk(KERN_ERR "can not alloc irq_desc\n");
> +		printk(KERN_ERR
> +		       "can not alloc irq_desc for irq %d on node %d\n",
> +		       irq, node);
>  		BUG_ON(1);
>  	}
>  	init_one_irq_desc(irq, desc, node);
>   
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/