linux-kernel - Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BBBC628.9030207@ti.com>
Date:	Tue, 6 Apr 2010 18:39:20 -0500
From:	Nishanth Menon <nm@...com>
To:	"Chikkature Rajashekar, Madhusudhan" <madhu.cr@...com>
CC:	"felipe.balbi@...ia.com" <felipe.balbi@...ia.com>,
	"me@...ipebalbi.com" <me@...ipebalbi.com>,
	"'kishore kadiyala'" <kishorek.kadiyala@...il.com>,
	"'Vimal Singh'" <vimal.newwork@...il.com>,
	"tony@...mide.com" <tony@...mide.com>,
	"S, Venkatraman" <svenkatr@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"'Lavinen Jarkko (Nokia-D/Helsinki)'" <jarkko.lavinen@...ia.com>
Subject: Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance.

Chikkature Rajashekar, Madhusudhan had written, on 04/06/2010 06:23 PM, 
the following:
> 
>> -----Original Message-----
>> From: Felipe Balbi [mailto:felipe.balbi@...ia.com]
>> Sent: Tuesday, April 06, 2010 11:57 AM
>> To: ext Nishanth Menon
>> Cc: Balbi Felipe (Nokia-D/Helsinki); Chikkature Rajashekar, Madhusudhan;
>> me@...ipebalbi.com; 'kishore kadiyala'; 'Vimal Singh'; tony@...mide.com;
>> S, Venkatraman; linux-omap@...r.kernel.org; linux-kernel@...r.kernel.org;
>> Lavinen Jarkko (Nokia-D/Helsinki)
>> Subject: Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's
>> peformance.
>>
>> On Tue, Apr 06, 2010 at 06:55:03PM +0200, ext Nishanth Menon wrote:
>>> some reasons why i love switch statements ;) since I dont expect other
>>> than precisely 4 and 8 (do we expect 5,6,7 - i might be wrong).. but if
>>> it is so, wont the following be better?
>>>
>>> switch (mmc_slot(host).wires)
>>> {
>>> case 8:
>>> 	mmc->caps |= MMC_CAP_8_BIT_DATA;
>>> 	/* fall thru*/
>>> case 4:
>>> 	mmc->caps |= MMC_CAP_4_BIT_DATA;
>>> 		break;
>>> default:
>>> 	WARN("bad width");
>>> }
>> I like that, but I remember Madhu (or someone else) saying he thinks
>> it's less readable this way. Go figure...
>>
> Well, I did not comment on the usage of switch here. Note we only need to
> handle 8-bit and 4-bit.The board files need not setup 8-bit or 4-bit if the
> configuration of that board is 1-bit. The driver will still work in 1-bit
> mode which would mean there is nothing to do in default case and should not
> err out.
check the attachment out.. hope that takes care of it.. just as a 
reference alone ofcourse..
-- 
Regards,
Nishanth Menon

View attachment "0001-OMAP-Fix-for-bus-width-which-improves-SD-card-s-pefo.patch" of type "text/x-patch" (2371 bytes)