linux-kernel - Re: [PATCH 1/2] sparc64: Implement local_irq_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1270625059.5109.537.camel@twins>
Date:	Wed, 07 Apr 2010 09:24:19 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	David Miller <davem@...emloft.net>
Cc:	mingo@...e.hu, acme@...hat.com, paulus@...ba.org, efault@....de,
	fweisbec@...il.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH 1/2] sparc64: Implement local_irq_save_nmi().

On Wed, 2010-04-07 at 00:06 -0700, David Miller wrote:
> From: Peter Zijlstra <peterz@...radead.org>
> Date: Wed, 07 Apr 2010 08:52:26 +0200
> 
> > On Tue, 2010-04-06 at 16:39 -0700, David Miller wrote:
> >> @@ -49,6 +49,16 @@ static inline void raw_local_irq_disable(void)
> >>  	);
> >>  }
> >>  
> >> +static inline void raw_local_irq_disable_nmi(void)
> >> +{
> >> +	__asm__ __volatile__(
> >> +		"wrpr	%0, %%pil"
> >> +		: /* no outputs */
> >> +		: "i" (PIL_NMI)
> >> +		: "memory"
> >> +	);
> >> +}
> >> +
> > 
> > Isn't this wrong when used from !NMI context?
> > 
> > Should this thing do something like:
> > 
> >   if (rdpr() < PIL_NORMAL_MAX)
> >     wrpr(PIL_NORMAL_MAX);
> > 
> > so that it only disables IRQs, but doesn't enable NMIs.
> 
> It's immaterial, local_irq_restore() will do the right thing,
> and it's ok to disable NMIs in these few cases I think.
> 
> I desperately want to avoid that "test and maybe change the
> value %pil value we write" business, and honestly that's
> the whole point of this exercise.

Sure, its your architecture.. but could you explain why you're trying to
avoid that compare so desperately, the local_irq_save_nmi() calls are
few so surely they could carry that overhead.

Also, doesn't __raw_local_irq_save_flags() already do the read? So its
really just the compare that's gone missing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/