linux-kernel - Re: [patch v2] dma-debug: cleanup for loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100407100512.GJ28166@amd.com>
Date:	Wed, 7 Apr 2010 12:05:12 +0200
From:	Joerg Roedel <joerg.roedel@....com>
To:	Dan Carpenter <error27@...il.com>, Joerg Roedel <joro@...tes.org>,
	Ingo Molnar <mingo@...e.hu>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Shaun Ruffell <sruffell@...ium.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch v2] dma-debug: cleanup for loop

On Tue, Apr 06, 2010 at 07:45:12PM +0300, Dan Carpenter wrote:
> Earlier in this function we set the last byte of "buf" to NULL so we 
> always hit the break statement and "i" is never equal to NAME_MAX_LEN.  
> This patch doesn't change how the driver works but it silences a Smatch 
> warning and it makes it clearer that we don't write past the end of the 
> array.
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>
> 
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index ba8b670..01e6427 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
>  	 * Now parse out the first token and use it as the name for the
>  	 * driver to filter for.
>  	 */
> -	for (i = 0; i < NAME_MAX_LEN; ++i) {
> +	for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
>  		current_driver_name[i] = buf[i];
>  		if (isspace(buf[i]) || buf[i] == ' ' || buf[i] == 0)
>  			break;

Applied, thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/