linux-kernel - Re: [PATCH 2/2] ftrace: Use local_irq_{save,restore}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100406.181717.01368166.davem@davemloft.net>
Date:	Tue, 06 Apr 2010 18:17:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rostedt@...dmis.org
Cc:	a.p.zijlstra@...llo.nl, mingo@...e.hu, acme@...hat.com,
	paulus@...ba.org, efault@....de, fweisbec@...il.com,
	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	sparclinux@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 2/2] ftrace: Use local_irq_{save,restore}_nmi() in
 tracers.

From: Steven Rostedt <rostedt@...dmis.org>
Date: Tue, 06 Apr 2010 21:14:10 -0400

> On Tue, 2010-04-06 at 16:40 -0700, David Miller wrote:
>> Signed-off-by: David S. Miller <davem@...emloft.net>
>> ---
>>  kernel/trace/ftrace.c             |    4 ++--
>>  kernel/trace/trace_functions.c    |    8 ++++----
>>  kernel/trace/trace_sched_wakeup.c |    4 ++--
>>  kernel/trace/trace_stack.c        |    4 ++--
>>  4 files changed, 10 insertions(+), 10 deletions(-)
>> 
>> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
>> index d9062f5..41d4282 100644
>> --- a/kernel/trace/ftrace.c
>> +++ b/kernel/trace/ftrace.c
>> @@ -612,7 +612,7 @@ function_profile_call(unsigned long ip, unsigned long parent_ip)
>>  	if (!ftrace_profile_enabled)
>>  		return;
>>  
>> -	local_irq_save(flags);
>> +	local_irq_save_nmi(flags);
> 
> These are equivalent for non sparc archs, correct?

Yes.

> If so,
> 
> Acked-by: Steven Rostedt <rostedt@...dmis.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/