linux-kernel - Re: [PATCH] eepc-wmi.c: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <z2g9c2470ce1004070855g7965443cl6d807051bb386dbb@mail.gmail.com>
Date:	Wed, 7 Apr 2010 17:55:56 +0200
From:	Jan III Sobieski <jan3sobi3ski@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Matthew Garrett <mjg@...hat.com>, Dmitry Torokhov <dtor@...l.ru>,
	Yong Wang <yong.y.wang@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] eepc-wmi.c: Fix build error

2010/4/7 Ingo Molnar <mingo@...e.hu>:
>
> * Jan III Sobieski <jan3sobi3ski@...il.com> wrote:
>
>> Hi,
>>
>>   GEN     .version
>>   CHK     include/generated/compile.h
>>   UPD     include/generated/compile.h
>>   CC      init/version.o
>>   LD      init/built-in.o
>>   LD      .tmp_vmlinux1
>> drivers/built-in.o: In function `eeepc_wmi_notify':
>> /home/test/linux-2.6/drivers/platform/x86/eeepc-wmi.c:86: undefined
>> reference to `sparse_keymap_report_event'
>
> -tip testing has triggered this bug too, see the fix below.

Works here. Thanks!

Tested-by: Jan III Sobieski <jan3sobi3ski@...il.com>

>
>        Ingo
>
> --------------------------->
> From 763400ebb305711ebbd468c030db76d631400fe1 Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@...e.hu>
> Date: Wed, 7 Apr 2010 16:15:51 +0200
> Subject: [PATCH] eepc-wmi.c: Fix build error
>
> -tip testing found:
>
> eeepc-wmi.c:(.text+0x36673c): undefined reference to `sparse_keymap_report_event'
> drivers/built-in.o: In function `eeepc_wmi_init':
> eeepc-wmi.c:(.init.text+0x19cd0): undefined reference to `sparse_keymap_setup'
> eeepc-wmi.c:(.init.text+0x19cf0): undefined reference to `sparse_keymap_free'
> eeepc-wmi.c:(.init.text+0x19d0b): undefined reference to `sparse_keymap_free'
> drivers/built-in.o: In function `eeepc_wmi_exit':
> eeepc-wmi.c:(.exit.text+0x2e87): undefined reference to `sparse_keymap_free'
>
> To fix this select INPUT_SPARSEKMAP, like the ASUS driver does.
>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  drivers/platform/x86/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 3046776..301e379 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -392,6 +392,7 @@ config EEEPC_WMI
>        depends on ACPI_WMI
>        depends on INPUT
>        depends on EXPERIMENTAL
> +       select INPUT_SPARSEKMAP
>        ---help---
>          Say Y here if you want to support WMI-based hotkeys on Eee PC laptops.
>
>



-- 
Jan III Sobieski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/