[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100407192246.GA5040@phenom.dumpdata.com>
Date: Wed, 7 Apr 2010 15:22:46 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc: linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
albert_herranz@...oo.es, Ian.Campbell@...citrix.com,
jeremy@...p.org, chrisw@...s-sol.org, dwmw2@...radead.org,
alex.williamson@...com
Subject: Re: [PATCH 4/5] swiotlb: Make swiotlb bookkeeping functions
visible in the header file.
> > +extern char *swiotlb_bk_start;
> > +extern char *swiotlb_bk_end;
> > +extern unsigned long swiotlb_bk_nslabs;
>
> exporting swiotlb_bk_start and swiotlb_bk_nslabs aren't enough?
It is.
>
>
> > +extern void *swiotlb_bk_overflow_buffer;
> > +extern unsigned long swiotlb_bk_overflow;
> > +extern int is_swiotlb_buffer(phys_addr_t paddr);
> > +extern void *swiotlb_bk_map_single(struct device *hwdev, phys_addr_t phys,
> > + unsigned long start_dma_addr, size_t size, int dir);
>
> enum dma_data_direction is better for 'dir'.
Done. I had to make a bigger change that would also change other
functions usage of 'int dir' -> 'enum ..' otherwise we had compiler
warnings.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists