linux-kernel - Re: [PATCH Resubmission] drivers/net/usb: Add new driver ipheth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada6342zy78.fsf@roland-alpha.cisco.com>
Date:	Wed, 07 Apr 2010 15:37:15 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	"L. Alberto Giménez" <agimenez@...valve.es>
Cc:	linux-kernel@...r.kernel.org, dgiagio@...il.com, dborca@...oo.com,
	Greg Kroah-Hartman <gregkh@...e.de>,
	"David S. Miller" <davem@...emloft.net>,
	Jonas Sjöquist <jonas.sjoquist@...csson.com>,
	Steve Glendinning <steve.glendinning@...c.com>,
	Torgny Johansson <torgny.johansson@...il.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Omar Laazimani <omar.oberthur@...il.com>,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH Resubmission] drivers/net/usb: Add new driver ipheth

These are a few of the cosmetic issues alluded to, and by no means merge
blockers, but:

 > +	schedule_delayed_work(&dev->carrier_work, IPHETH_CARRIER_CHECK_TIMEOUT);

Seems this might as well be round_jiffies_relative(IPHETH_CARRIER_CHECK_TIMEOUT)
to avoid extra wakeups.

 > +	netdev = alloc_etherdev(sizeof(struct ipheth_device));

This means that the interface will get an ethX name and look to
networkmanager et al like an ethernet device.  Seems we would maybe want
to make this a "wwan" type device (cf drivers/net/usb/usbnet.c and how
it handles FLAG_WWAN)?

 - R.
-- 
Roland Dreier <rolandd@...co.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/