| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100408090114.GA31407@n2100.arm.linux.org.uk> Date: Thu, 8 Apr 2010 10:01:14 +0100 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Claudio Scordino <claudio@...dence.eu.com> Cc: Ryan Mallon <ryan@...ewatersys.com>, Linux Kernel <linux-kernel@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, John Nicholls <john@...nlinx.com>, Rick Bronson <rick@....org>, Sebastian Heutling <Sebastian.Heutling@...-ing.de>, michael trimarchi <michael@...dence.eu.com>, alan@...rguk.ukuu.org.uk, hskinnemoen@...el.com, linux@...im.org.za Subject: Re: [PATCH] atmel_serial: Atmel RS485 support v2 On Thu, Apr 08, 2010 at 09:58:21AM +0200, Claudio Scordino wrote: > diff --git a/arch/arm/include/asm/ioctls.h b/arch/arm/include/asm/ioctls.h > index a91d8a1..82f2177 100644 > --- a/arch/arm/include/asm/ioctls.h > +++ b/arch/arm/include/asm/ioctls.h > @@ -70,6 +70,8 @@ > #define TIOCGICOUNT 0x545D /* read serial port inline interrupt counts */ > #define FIOQSIZE 0x545E > > +#define TIOCSRS485 0x5461 Why are you only supporting half the interface? #define TIOCGRS485 0x542E #define TIOCSRS485 0x542F is what is in include/asm-generic/ioctls.h - and it would be a good idea to use the same numbering as the generic file rather than creating yet more divergence. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists