lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4BBDA92B.8010505@ladisch.de>
Date:	Thu, 08 Apr 2010 12:00:11 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Tvrtko Ursulin <tvrtko@...ulin.net>, Takashi Iwai <tiwai@...e.de>
CC:	alsa-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: Ooops when working with USB MIDI (2.6.33.1)

Tvrtko Ursulin wrote:
> I had TuxGuitar running and an external USB MIDI device, which I then
> turned off, on, and exited TuxGuitar at which point there was this oops.
> ...
> [321182.618342] IP: [<ffffffff81375d65>] _raw_spin_lock_irq+0x15/0x30                                                                               
> [321182.618449]  [<ffffffffa01e2fca>] ? snd_usbmidi_output_drain+0x7a/0x100 [snd_usb_lib]
> [321182.618462]  [<ffffffffa01b7699>] ? snd_rawmidi_drain_output+0x119/0x180 [snd_rawmidi]

I think that bug was introduced by this commit:
http://git.kernel.org/linus/7a17daae8ed71bf3259d905a4fc48a5b424fa935
which causes the driver to free many internal data structures when
they might still be in use by userspace.

Please try to revert it.

I think a proper fix would be to free the URBs/buffers but not the
driver's data structures.

Takashi, do you remember what the original problem was?


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ