linux-kernel - Re: [patch] wd7000: typo spin_unlock_irq() => spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1004081629350.8345@pobox.suse.cz>
Date:	Thu, 8 Apr 2010 16:30:04 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Dan Carpenter <error27@...il.com>
Cc:	Miroslav Zagorac <zaga@....cc.fer.hr>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	Adam Buchbinder <adam.buchbinder@...il.com>, jgarzik@...ox.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] wd7000: typo spin_unlock_irq() => spin_lock_irq()

On Thu, 1 Apr 2010, Dan Carpenter wrote:

> This was introduced back in 2005 at the very start of the git era by:
> 	df0ae2497ddefd72a87f3a3b34ff32455d7d4ae0
> 	[SCSI] allow sleeping in ->eh_host_reset_handler()
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>
> ---
> Also this driver was written before some of our youngest kernel hackers
> were born.  Neat.  :)
> 
> diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
> index 2f6e9d8..bdfe59d 100644
> --- a/drivers/scsi/wd7000.c
> +++ b/drivers/scsi/wd7000.c
> @@ -1588,7 +1588,7 @@ static int wd7000_host_reset(struct scsi_cmnd *SCpnt)
>  {
>  	Adapter *host = (Adapter *) SCpnt->device->host->hostdata;
>  
> -	spin_unlock_irq(SCpnt->device->host->host_lock);
> +	spin_lock_irq(SCpnt->device->host->host_lock);
>  

Doesn't seem to be present in today's linux-next, so I have queued it in 
my tree so that it doesn't get lost.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/