linux-kernel - [PATCH] Revert "memory-hotplug: add 0x prefix to HEX block_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100408151006.GB2446@osiris.boeblingen.de.ibm.com>
Date:	Thu, 8 Apr 2010 17:10:06 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	Wu Fengguang <fengguang.wu@...el.com>,
	Andi Kleen <andi@...stfloor.org>, Greg KH <greg@...ah.com>,
	Gerald Schaefer <gerald.schaefer@...ibm.com>, stable@...nel.org
Subject: [PATCH] Revert "memory-hotplug: add 0x prefix to HEX
 block_size_bytes"

From: Heiko Carstens <heiko.carstens@...ibm.com>

Revert ba168fc37dea145deeb8fa9e7e71c748d2e00d74 "memory-hotplug: add 0x prefix
to HEX block_size_bytes" since it changes the user space visible sysfs interface
/sys/devices/system/memory/block_size_bytes.
The change breaks existing user space applications which rely on the fact that
the output does not contain the "0x" prefix.

Cc: Wu Fengguang <fengguang.wu@...el.com>
Cc: Andi Kleen <andi@...stfloor.org>
Cc: Greg KH <greg@...ah.com>
Cc: Gerald Schaefer <gerald.schaefer@...ibm.com>
Cc: stable@...nel.org
Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
---

 drivers/base/memory.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 4f4aa58..933442f 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -313,7 +313,7 @@ static ssize_t
 print_block_size(struct sysdev_class *class, struct sysdev_class_attribute *attr,
 		 char *buf)
 {
-	return sprintf(buf, "%#lx\n", (unsigned long)PAGES_PER_SECTION * PAGE_SIZE);
+	return sprintf(buf, "%lx\n", (unsigned long)PAGES_PER_SECTION * PAGE_SIZE);
 }
 
 static SYSDEV_CLASS_ATTR(block_size_bytes, 0444, print_block_size, NULL);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/