lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <003601cad73c$98c3aa50$544ff780@am.dhcp.ti.com>
Date:	Thu, 8 Apr 2010 11:57:39 -0500
From:	"Madhusudhan" <madhu.cr@...com>
To:	"'Nishanth Menon'" <nm@...com>
Cc:	<felipe.balbi@...ia.com>, <me@...ipebalbi.com>,
	"'kishore kadiyala'" <kishorek.kadiyala@...il.com>,
	"'Vimal Singh'" <vimal.newwork@...il.com>, <tony@...mide.com>,
	"'S, Venkatraman'" <svenkatr@...com>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	"'Lavinen Jarkko \(Nokia-D/Helsinki\)'" <jarkko.lavinen@...ia.com>
Subject: RE: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance.

<snip>
> Point noted. try n++:
> switch(mmc_slot(host).wires) {
> case 8:
>          mmc->caps |= MMC_CAP_8_BIT_DATA;
>          /* Fall through */
> case 4:
>          mmc->caps |= MMC_CAP_4_BIT_DATA;
>          break;
> case 0:
>          /* assuming nothing was given by board, use 1 */
> case 1:
>          /* nothing to crib here */
>          break;
> default:
>          /* Completely unexpected.. try 1 bit instead  */
>          dev_crit(mmc_dev(host->mmc), "Invalid width %d"
>                          " used! using 1 instead\n",
>                          mmc_slot(host).wires);
> }
> 
> note: we should crib if the board file made a mistake here.. say it gave
> 10 wire or so.. I agree that we can recover by stepping back to 1 bit
> mode.. but we gotta tell the log that something aint right..
> 

Sure. It looks fine to me now.

Regards,
Madhu
> --
> Regards,
> Nishanth Menon

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ